From b0a5b1d13f1d5743cdc44d7e92ae6a6186d42ab5 Mon Sep 17 00:00:00 2001
From: Christian Zimmermann <christian.zimmermann@ur.de>
Date: Fri, 8 Sep 2023 19:18:54 +0200
Subject: [PATCH] WIP: deepFormat + check format compatibility

---
 src/include/array/array_base.cc.h |  12 +--
 src/include/array/array_base.h    |   2 +
 src/include/base/base.h           |   1 +
 src/include/base/utils.h          | 136 ++++++++++++++++++++++++++++++
 src/include/ranges/crange.h       |   2 +
 src/include/ranges/mrange.cc.h    |   4 +-
 src/include/ranges/urange.cc.h    |   6 ++
 src/include/ranges/urange.h       |   2 +
 src/include/ranges/xindex.cc.h    |   7 ++
 src/include/ranges/xindex.h       |   2 +
 src/include/ranges/yrange.h       |   1 +
 11 files changed, 168 insertions(+), 7 deletions(-)
 create mode 100644 src/include/base/utils.h

diff --git a/src/include/array/array_base.cc.h b/src/include/array/array_base.cc.h
index 0cab6c7..90db3ce 100644
--- a/src/include/array/array_base.cc.h
+++ b/src/include/array/array_base.cc.h
@@ -100,7 +100,7 @@ namespace CNORXZ
     template <class Index>
     COpRoot<T,Index> CArrayBase<T>::operator()(const Sptr<Index>& i) const
     {
-	CXZ_WARNING("FORMAT / BLOCKSIZES!!!");
+	this->checkFormatCompatibility(i->deepFormat());
 	return coproot(*this, i);
     }
 
@@ -108,15 +108,17 @@ namespace CNORXZ
     template <class... Indices>
     inline decltype(auto) CArrayBase<T>::operator()(const SPack<Indices...>& pack) const
     {
-	CXZ_WARNING("FORMAT / BLOCKSIZES!!!");
-	return coproot(*this, mindexPtr(pack));
+	auto i = mindexPtr(pack);
+	this->checkFormatCompatibility(i->deepFormat());
+	return coproot(*this, i);
     }
 
     template <typename T>
     inline decltype(auto) CArrayBase<T>::operator()(const DPack& pack) const
     {
-	CXZ_WARNING("FORMAT / BLOCKSIZES!!!");
-	return coproot(*this, yindexPtr(pack));
+	auto i = yindexPtr(pack);
+	this->checkFormatCompatibility(i->deepFormat());
+	return coproot(*this, i);
     }
 
     /******************************
diff --git a/src/include/array/array_base.h b/src/include/array/array_base.h
index 0580b15..7bec6f0 100644
--- a/src/include/array/array_base.h
+++ b/src/include/array/array_base.h
@@ -69,6 +69,8 @@ namespace CNORXZ
 
 	template <class Acc>
 	const_iterator itLexSave(const Acc& acc) const;
+
+	void checkFormatCompatibility(const Vector<SizeT>& f) const { CXZ_WARNING("FORMAT / BLOCKSIZES!!!"); }
     };
 
     template <typename T>
diff --git a/src/include/base/base.h b/src/include/base/base.h
index 033801f..e6a401a 100644
--- a/src/include/base/base.h
+++ b/src/include/base/base.h
@@ -25,6 +25,7 @@
 #include "isq.h"
 #include "iter.h"
 #include "uuid.h"
+#include "utils.h"
 #include "config.h"
 
 #include "base.cc.h"
diff --git a/src/include/base/utils.h b/src/include/base/utils.h
new file mode 100644
index 0000000..8646cfa
--- /dev/null
+++ b/src/include/base/utils.h
@@ -0,0 +1,136 @@
+
+#ifndef __cxz_utils_h__
+#define __cxz_utils_h__
+
+#include <cstdlib>
+#include "types.h"
+
+namespace CNORXZ
+{
+    template <typename T, SizeT N>
+    Vector<T> toVec(const Arr<T,N>& a)
+    {
+	return iter<0,N>( [&](auto i) { return std::get<i>(a); },
+			  [](const auto&... e) { return Vector<T> { e... }; } );
+    }
+
+    template <typename T>
+    Vector<T> toVec(const Vector<T>& a)
+    {
+	return a;
+    }
+
+    template <typename T>
+    Vector<T> toVec(const T& a)
+    {
+	return Vector<T> { a };
+    }
+    
+    template <typename T, SizeT N1, SizeT N2>
+    constexpr Arr<T,N1+N2> cat2(const Arr<T,N1>& a1, const Arr<T,N2>& a2)
+    {
+	return iter<0,N1+N2>
+	    ( [&](auto i) { if constexpr(i < N1) { return std::get<i>(a1); } else { return std::get<i-N1>(a2); } },
+	      [](const auto&... e) { return Arr<T,N1+N2> { e... }; } );
+    }
+
+    template <typename T, SizeT N1>
+    constexpr Arr<T,N1+1> cat2(const Arr<T,N1>& a1, const T& a2)
+    {
+	return iter<0,N1>
+	    ( [&](auto i) { return std::get<i>(a1); },
+	      [](const auto&... e) { return Arr<T,N1+1> { e..., a2 }; } );
+    }
+
+    template <typename T, SizeT N1>
+    constexpr Arr<T,N1+1> cat2(const T& a1, const Arr<T,N1>& a2)
+    {
+	return iter<0,N1>
+	    ( [&](auto i) { return std::get<i>(a2); },
+	      [](const auto&... e) { return Arr<T,N1+1> { a1, e... }; } );
+    }
+
+    template <typename T>
+    constexpr Arr<T,2> cat2(const T& a1, const T& a2)
+    {
+	return Arr<T,2> { a1, a2 };
+    }
+
+    template <typename T, SizeT N2>
+    Vector<T> cat2(const Vector<T>& a1, const Arr<T,N2>& a2)
+    {
+	Vector<T> o(a1.size()+N2);
+	std::copy(a1.begin(), a1.end(), o.begin());
+	std::copy(a2.begin(), a2.end(), o.begin()+a1.size());
+	return o;
+    }
+
+    template <typename T, SizeT N1>
+    Vector<T> cat2(const Arr<T,N1>& a1, const Vector<T>& a2)
+    {
+	Vector<T> o(N1+a2.size());
+	std::copy(a1.begin(), a1.end(), o.begin());
+	std::copy(a2.begin(), a2.end(), o.begin()+N1);
+	return o;
+    }
+
+    template <typename T>
+    Vector<T> cat2(const Vector<T>& a1, const Vector<T>& a2)
+    {
+	Vector<T> o(a1.size()+a2.size());
+	std::copy(a1.begin(), a1.end(), o.begin());
+	std::copy(a2.begin(), a2.end(), o.begin()+a1.size());
+	return o;
+    }
+
+    template <typename T>
+    Vector<T> cat2(const Vector<T>& a1, const T& a2)
+    {
+	Vector<T> o(a1);
+	o.push_back(a2);
+	return o;
+    }
+
+    template <typename T, SizeT N1>
+    Vector<T> cat2(const T& a1, const Vector<T>& a2)
+    {
+	Vector<T> o { a1 };
+	o.insert(o.end(), a2.begin(), a2.end());
+	return o;
+    }
+
+    template <typename T1, typename T2, typename... Ts>
+    decltype(auto) concat(const T1& a1, const T2& a2, const Ts&... as)
+    {
+	if constexpr(sizeof...(Ts) != 0){
+	    return cat2(a1, concat(a2, as...));
+	}
+	else {
+	    return cat2(a1, a2);
+	}
+    }
+
+    template <typename T, SizeT N>
+    constexpr Arr<T,N> mul(const Arr<T,N>& a, const T& b)
+    {
+	return iter<0,N>( [&](auto i) { return std::get<i>(a) * b },
+			  [](const auto&... e) { return Arr<T,N> { e... }; } );
+    }
+
+    template <typename T>
+    Vector<T> mul(const Vector<T>& a, const T& b)
+    {
+	Vector<T> o(a.size());
+	std::transform(a.begin(), a.end(), o.begin(), [&](const auto& x) { return x*b; } );
+	return o;
+    }
+
+    template <typename T>
+    constexpr T mul(const T& a, const T& b)
+    {
+	return a*b;
+    }
+
+}
+
+#endif
diff --git a/src/include/ranges/crange.h b/src/include/ranges/crange.h
index 913796a..6c344c0 100644
--- a/src/include/ranges/crange.h
+++ b/src/include/ranges/crange.h
@@ -47,6 +47,8 @@ namespace CNORXZ
 	CIndex& at(const SizeT& metaPos);
 	COpRoot<SizeT,CIndex> xpr(const Sptr<CIndex>& _this) const;
 
+	SizeT deepFormat() const { return 1; }
+	
 	template <class Index>
 	decltype(auto) formatFrom(const Index& ind) const;
 
diff --git a/src/include/ranges/mrange.cc.h b/src/include/ranges/mrange.cc.h
index 3a6801b..2a5efbc 100644
--- a/src/include/ranges/mrange.cc.h
+++ b/src/include/ranges/mrange.cc.h
@@ -482,8 +482,8 @@ namespace CNORXZ
     template <class FormatT, class... Indices>
     auto GMIndex<FormatT,Indices...>::deepFormat() const
     {
-	return iter<0,NI>( [&](auto i) { return std::get<i>(mIPack)->deepFormat(); },
-			   [&](const auto&... e) { return (e * ...); } );
+	return iter<0,NI>( [&](auto i) { return mul(std::get<i>(mIPack)->deepFormat(), mFormat[i]); },
+			   [&](const auto&... e) { return concat(e, ...); } );
     }
 
     template <class FormatT, class... Indices>
diff --git a/src/include/ranges/urange.cc.h b/src/include/ranges/urange.cc.h
index c35a5e7..ebeeab5 100644
--- a/src/include/ranges/urange.cc.h
+++ b/src/include/ranges/urange.cc.h
@@ -126,6 +126,12 @@ namespace CNORXZ
 	return coproot(mMetaPtr,_this);
     }
 
+    template <typename MetaType>
+    SizeT UIndex<MetaType>::deepFormat() const
+    {
+	return 1;
+    }
+
     template <typename MetaType>
     size_t UIndex<MetaType>::dim() const // = 1
     {
diff --git a/src/include/ranges/urange.h b/src/include/ranges/urange.h
index 78b62e5..54a1923 100644
--- a/src/include/ranges/urange.h
+++ b/src/include/ranges/urange.h
@@ -55,6 +55,8 @@ namespace CNORXZ
 	UIndex& at(const MetaT& metaPos);
 	decltype(auto) xpr(const Sptr<UIndex<MetaType>>& _this) const;
 
+	SizeT deepFormat() const;
+	
 	template <class Index>
 	decltype(auto) formatFrom(const Index& ind) const;
 
diff --git a/src/include/ranges/xindex.cc.h b/src/include/ranges/xindex.cc.h
index 6fd6601..65df9e8 100644
--- a/src/include/ranges/xindex.cc.h
+++ b/src/include/ranges/xindex.cc.h
@@ -126,6 +126,13 @@ namespace CNORXZ
     {
 	return mI->stepSize(id);
     }
+
+    template <class Index, typename Meta>
+    Vector<SizeT> XIndex<Index,Meta>::deepFormat() const
+    {
+	return toVec( mI->deepFormat() );
+    }
+    
     /*
     template <class Index, typename Meta>
     Vector<XIndexPtr> XIndex<Index,Meta>::pack() const
diff --git a/src/include/ranges/xindex.h b/src/include/ranges/xindex.h
index 9940b4a..93bb23d 100644
--- a/src/include/ranges/xindex.h
+++ b/src/include/ranges/xindex.h
@@ -38,6 +38,7 @@ namespace CNORXZ
 	virtual SizeT dim() const = 0;
 	virtual RangePtr range() const = 0;
 	virtual UPos stepSize(const IndexId<0>& id) const = 0;
+	virtual Vector<SizeT> deepFormat() const = 0;
 	//virtual Vector<XIndexPtr> pack() const = 0;
 	//virtual Vector<SizeT> format() const = 0;
 	//virtual XIndexPtr setBlockSizes(const Vector<SizeT>& bs) = 0;
@@ -91,6 +92,7 @@ namespace CNORXZ
 	virtual SizeT dim() const override final;
 	virtual RangePtr range() const override final;
 	virtual UPos stepSize(const IndexId<0>& id) const override final;
+	virtual Vector<SizeT> deepFormat() const override final;
 	//virtual Vector<XIndexPtr> pack() const override final;
 	//virtual Vector<SizeT> format() const override final;
 	//virtual XIndexPtr setBlockSizes(const Vector<SizeT>& bs) override final;
diff --git a/src/include/ranges/yrange.h b/src/include/ranges/yrange.h
index 8e058ea..4104a5a 100644
--- a/src/include/ranges/yrange.h
+++ b/src/include/ranges/yrange.h
@@ -65,6 +65,7 @@ namespace CNORXZ
 	YIndex& operator()();
 
 	const DPack& pack() const;
+	Vector<SizeT> deepFormat() const;
 	const YFormat& format() const;
 	const YFormat& lexFormat() const;
 	YIndex& setFormat(const YFormat& bs);