From 42868e4a836a0ef9dbbcea29761c3d3666cbeeee Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Oliver=20R=C3=BCmpelein?= <oli_r@fg4f.de>
Date: Fri, 8 Jan 2021 23:46:28 +0100
Subject: [PATCH] Fix review comments.
---
src/module/rolls/check.ts | 7 +------
src/module/rolls/roll-executor.ts | 4 +---
2 files changed, 2 insertions(+), 9 deletions(-)
diff --git a/src/module/rolls/check.ts b/src/module/rolls/check.ts
index 58cba71d..5886813c 100644
--- a/src/module/rolls/check.ts
+++ b/src/module/rolls/check.ts
@@ -12,7 +12,7 @@ interface TermData {
* Implements DS4 Checks as an emulated "dice throw".
*
* @notes
- * Be aware that, even though this behaves like one roll, it actually throws several iones internally
+ * Be aware that, even though this behaves like one roll, it actually throws several ones internally
*
* @example
* - Roll a check against a Check Target Number (CTV) of 18: `/r dsv18`
@@ -29,7 +29,6 @@ export class DS4Check extends DiceTerm {
modifiers: termData.modifiers ?? [],
options: termData.options ?? {},
});
- console.log("This @ constructor: ", termData);
// Store and parse target value.
const targetValueModifier = this.modifiers.filter((m) => m[0] === "v")[0];
@@ -65,12 +64,8 @@ export class DS4Check extends DiceTerm {
/**
* @override
- * @param param0
- *
- * @private_notes This gets only called once for the first roll.
*/
roll({ minimize = false, maximize = false } = {}): RollResult {
- console.log(`This targetValue @ roll: ${this.targetValue}`);
const rollResult = this.rollWithDifferentBorders({ minimize, maximize });
this.results.push(rollResult);
if (rollResult.status == RollResultStatus.CRITICAL_SUCCESS) {
diff --git a/src/module/rolls/roll-executor.ts b/src/module/rolls/roll-executor.ts
index 3efe386f..72e6b2c4 100644
--- a/src/module/rolls/roll-executor.ts
+++ b/src/module/rolls/roll-executor.ts
@@ -40,10 +40,8 @@ export function rollCheckSingleDie(
): RollResult {
const usedOptions = new DefaultRollOptions().mergeWith(rollOptions);
- if (dice == null || dice.length != 1) {
- console.error(`Rolled a dice. Target: ${checkTargetValue}`);
+ if (dice?.length != 1) {
dice = [new DS4RollProvider().getNextRoll()];
- console.log(dice);
}
const usedDice = dice;
const rolledDie = usedDice[0];