From 7e4c5059caa124b117e967bff811363e4c46e7df Mon Sep 17 00:00:00 2001
From: Johannes Loher <johannes.loher@fg4f.de>
Date: Mon, 18 Jan 2021 19:11:13 +0100
Subject: [PATCH] address code review comments

---
 src/lang/de.json                                    | 6 +++---
 src/lang/en.json                                    | 2 +-
 src/module/config.ts                                | 4 ++--
 src/templates/actor/partials/items-overview.hbs     | 1 -
 src/templates/item/specialCreatureAbility-sheet.hbs | 4 ++--
 5 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/src/lang/de.json b/src/lang/de.json
index 0a0cc843..e1b11e81 100644
--- a/src/lang/de.json
+++ b/src/lang/de.json
@@ -57,8 +57,8 @@
     "DS4.ItemTypeLanguagePlural": "Sprachen",
     "DS4.ItemTypeAlphabet": "Schriftzeichen",
     "DS4.ItemTypeAlphabetPlural": "Schriftzeichen",
-    "DS4.ItemTypeSpecialCreatureAbility": "Besondere Kreaturefähigkeit",
-    "DS4.ItemTypeSpecialCreatureAbilityPlural": "Besondere Kreaturefähigkeiten",
+    "DS4.ItemTypeSpecialCreatureAbility": "Besondere Kreaturenfähigkeit",
+    "DS4.ItemTypeSpecialCreatureAbilityPlural": "Besondere Kreaturenfähigkeiten",
     "DS4.ArmorType": "Panzerungstyp",
     "DS4.ArmorTypeAbbr": "PAT",
     "DS4.ArmorMaterialType": "Material Typ",
@@ -145,7 +145,7 @@
     "DS4.CharacterProfileBirthplace": "Geburtsort",
     "DS4.CharacterProfileAge": "Alter",
     "DS4.CharacterProfileHeight": "Größe",
-    "DS4.ProfilHairColor": "Haarfarbe",
+    "DS4.ProfilEHairColor": "Haarfarbe",
     "DS4.CharacterProfileWeight": "Gewicht",
     "DS4.CharacterProfileEyeColor": "Augenfarbe",
     "DS4.CharacterProfileSpecialCharacteristics": "Besondere Eigenschaften",
diff --git a/src/lang/en.json b/src/lang/en.json
index 5b56e87a..470dc609 100644
--- a/src/lang/en.json
+++ b/src/lang/en.json
@@ -145,7 +145,7 @@
     "DS4.CharacterProfileBirthplace": "Birthplace",
     "DS4.CharacterProfileAge": "Age",
     "DS4.CharacterProfileHeight": "Height",
-    "DS4.ProfilHairColor": "Hair Color",
+    "DS4.ProfilEHairColor": "Hair Color",
     "DS4.CharacterProfileWeight": "Weight",
     "DS4.CharacterProfileEyeColor": "Eye Color",
     "DS4.CharacterProfileSpecialCharacteristics": "Special Characteristics",
diff --git a/src/module/config.ts b/src/module/config.ts
index 6f42ee13..63f22511 100644
--- a/src/module/config.ts
+++ b/src/module/config.ts
@@ -204,7 +204,7 @@ export const DS4 = {
         birthplace: "DS4.CharacterProfileBirthplace",
         age: "DS4.CharacterProfileAge",
         height: "DS4.CharacterProfileHeight",
-        hairColor: "DS4.ProfilHairColor",
+        hairColor: "DS4.ProfilEHairColor",
         weight: "DS4.CharacterProfileWeight",
         eyeColor: "DS4.CharacterProfileEyeColor",
         specialCharacteristics: "DS4.CharacterProfileSpecialCharacteristics",
@@ -239,7 +239,7 @@ export const DS4 = {
     },
 
     /**
-     * Define the different size categories a creatures fall into
+     * Define the different size categories creatures fall into
      */
     creatureSizeCategories: {
         tiny: "DS4.CreatureSizeCategoryTiny",
diff --git a/src/templates/actor/partials/items-overview.hbs b/src/templates/actor/partials/items-overview.hbs
index a76c714e..4d7135aa 100644
--- a/src/templates/actor/partials/items-overview.hbs
+++ b/src/templates/actor/partials/items-overview.hbs
@@ -1,4 +1,3 @@
-{{!-- TODO: For items list: only show header, if list is not empty --}}
 {{!-- TODO: Refactor to avoid code duplication with special-creature-abilites-overview and talents-overview --}}
 
 {{!-- ======================================================================== --}}
diff --git a/src/templates/item/specialCreatureAbility-sheet.hbs b/src/templates/item/specialCreatureAbility-sheet.hbs
index 3f100c3d..086ba9a5 100644
--- a/src/templates/item/specialCreatureAbility-sheet.hbs
+++ b/src/templates/item/specialCreatureAbility-sheet.hbs
@@ -3,8 +3,8 @@
     <div class="grid grid-3col basic-properties">
         <div class="basic-property">
             <label>{{localize "DS4.SpecialCreatureAbilityExperiencePoints"}}</label>
-            <input type="number" name="data.experiencePoints" value="{{data.experiencePoints}}" placeholder="0"
-                data-dtype="Number" />
+            <input type="number" min="0" step="1" name="data.experiencePoints" value="{{data.experiencePoints}}"
+                placeholder="0" data-dtype="Number" />
         </div>
     </div>
     {{/systems/ds4/templates/item/partials/sheet-header.hbs}}