From a0c4d1c4d9bf6bda1a17a50a052d16d0d5ced6ee Mon Sep 17 00:00:00 2001 From: Johannes Loher Date: Tue, 26 Jan 2021 03:58:03 +0100 Subject: [PATCH] small adjustments to TODO comments --- src/module/actor/sheets/actor-sheet.ts | 2 +- src/module/item/item-sheet.ts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/module/actor/sheets/actor-sheet.ts b/src/module/actor/sheets/actor-sheet.ts index e499b109..c72d79b4 100644 --- a/src/module/actor/sheets/actor-sheet.ts +++ b/src/module/actor/sheets/actor-sheet.ts @@ -117,7 +117,7 @@ export class DS4ActorSheet extends ActorSheet { }; // Finally, create the item! - return this.actor.createOwnedItem(itemData as DS4ItemData); // TODO(types) Improve upstream typing of createOwnedItem. It is possible to leave parts out here. + return this.actor.createOwnedItem(itemData as DS4ItemData); // TODO(types): Improve upstream typing of createOwnedItem. It is possible to leave parts out here. } /** diff --git a/src/module/item/item-sheet.ts b/src/module/item/item-sheet.ts index f974a76b..c29c9234 100644 --- a/src/module/item/item-sheet.ts +++ b/src/module/item/item-sheet.ts @@ -63,7 +63,7 @@ export class DS4ItemSheet extends ItemSheet { const position = super.setPosition(options); if ("find" in this.element) { const sheetBody = this.element.find(".sheet-body"); - const bodyHeight = (position.height as number) - 192; // TODO: remove type cast once https://github.com/kmoschcau/foundry-vtt-types/pull/214 is merged + const bodyHeight = (position.height as number) - 192; // TODO(types): remove type cast once https://github.com/kmoschcau/foundry-vtt-types/pull/214 is merged sheetBody.css("height", bodyHeight); } else { console.log("Failure setting position."); @@ -99,7 +99,7 @@ export class DS4ItemSheet extends ItemSheet { case "create": return this._createActiveEffect(); case "edit": - const effect = this.item["effects"].get(li.data("effectId")); // TODO replace with item.effect once https://github.com/kmoschcau/foundry-vtt-types/pull/216 is merged + const effect = this.item["effects"].get(li.data("effectId")); // TODO(types): replace with item.effect once https://github.com/kmoschcau/foundry-vtt-types/pull/216 is merged return effect.sheet.render(true); case "delete": { return this.item.deleteEmbeddedEntity("ActiveEffect", li.data("effectId"));