dungeonslayers/ds4
dungeonslayers/ds4
3
0
Fork 0
Code Issues 9 Pull requests 5 Packages Projects Releases 10 Activity

refactor: avoid unnecessary migrations
All checks were successful
ci/woodpecker/pr/checks Pipeline was successful
Details

Browse source
This commit is contained in:
Johannes Loher 2023-07-09 22:35:37 +02:00
parent 479923e80e
commit 9dfe07cf70
Signed by: saluu
GPG key ID: 7CB0A9FB553DA045
1 changed files with 31 additions and 30 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
src/migration/migrationHelpers.js
View file

@ -2,8 +2,6 @@
// //
// SPDX-License-Identifier: MIT // SPDX-License-Identifier: MIT
import { DS4Actor } from "../documents/actor/actor.js";
import { DS4Item } from "../documents/item/item.js";
import { logger } from "../utils/logger.js"; import { logger } from "../utils/logger.js";
import { getGame } from "../utils/utils.js"; import { getGame } from "../utils/utils.js";
@ -138,8 +136,15 @@ export function getCompendiumMigrator(
return async (pack) => { return async (pack) => {
/** @type {import("./migration.js").Result} */ /** @type {import("./migration.js").Result} */
let result = "success"; let result = "success";
const type = pack.metadata.type; const type = pack.metadata.type;
if (!["Actor", "Item", "Scene"].includes(type)) return; const migrateDocument = {
Item: migrateItem,
Actor: migrateActor,
Scene: migrateScene,
}[type];
if (migrateDocument) {
const wasLocked = pack.locked; const wasLocked = pack.locked;
await pack.configure({ locked: false }); await pack.configure({ locked: false });
if (migrateToTemplateEarly) { if (migrateToTemplateEarly) {
@ -151,13 +156,7 @@ export function getCompendiumMigrator(
for (const doc of documents) { for (const doc of documents) {
try { try {
logger.info(`Migrating document ${doc.name} (${doc.id}) in compendium ${pack.collection}`); logger.info(`Migrating document ${doc.name} (${doc.id}) in compendium ${pack.collection}`);
if (doc instanceof DS4Item && migrateItem) { await migrateDocument(doc);
await migrateItem(doc);
} else if (doc instanceof DS4Actor && migrateActor) {
await migrateActor(doc);
} else if (doc instanceof Scene && migrateScene) {
await migrateScene(doc);
}
} catch (err) { } catch (err) {
logger.error( logger.error(
`Error during migration of document ${doc.name} (${doc.id}) in compendium ${pack.collection}, continuing anyways.`, `Error during migration of document ${doc.name} (${doc.id}) in compendium ${pack.collection}, continuing anyways.`,
@ -171,6 +170,8 @@ export function getCompendiumMigrator(
await pack.migrate(); await pack.migrate();
} }
await pack.configure({ locked: wasLocked }); await pack.configure({ locked: wasLocked });
}
return result; return result;
}; };
} }