src/apps/actor/base-sheet.js

@@ -457,6 +457,27 @@ export class DS4ActorSheet extends ActorSheet {
 
     this.actor.updateEmbeddedDocuments("Item", updates);
   }
+
+  /**
+   * @param {DragEvent} event
+   * @param {object} data
+   * @override
+   */
+  async _onDropItem(event, data) {
+    const item = await Item.implementation.fromDropData(data);
+    if (item && !this.actor.canOwnItemType(item.type)) {
+      notifications.warn(
+        getGame().i18n.format("DS4.WarningActorCannotOwnItem", {
+          actorName: this.actor.name,
+          actorType: this.actor.type,
+          itemName: item.name,
+          itemType: item.type,
+        }),
+      );
+      return false;
+    }
+    return super._onDropItem(event, data);
+  }
 }
 
 /**

src/hooks/hooks.ts

@@ -4,14 +4,12 @@
 
 import { registerForHotbarDropHook } from "./hotbar-drop";
 import { registerForInitHook } from "./init";
-import { registerForPreCreateItemHook } from "./pre-create-item";
 import { registerForReadyHook } from "./ready";
 import { registerForRenderHooks } from "./render";
 import { registerForSetupHook } from "./setup";
 
 export function registerForHooks(): void {
   registerForHotbarDropHook();
-  registerForPreCreateItemHook();
   registerForInitHook();
   registerForReadyHook();
   registerForRenderHooks();

src/hooks/pre-create-item.js

@@ -1,28 +0,0 @@
-// SPDX-FileCopyrightText: 2023 Johannes Loher
-//
-// SPDX-License-Identifier: MIT
-
-import { notifications } from "../ui/notifications.js";
-import { getGame } from "../utils/utils.js";
-
-export function registerForPreCreateItemHook() {
-  Hooks.on("preCreateItem", preCreateItem);
-}
-
-/**
- * @param {import('../documents/item/item.js').DS4Item} item
- * @returns {void | false}
- */
-function preCreateItem(item) {
-  if (item.parent instanceof Actor && !item.parent.canOwnItemType(item.type)) {
-    notifications.warn(
-      getGame().i18n.format("DS4.WarningActorCannotOwnItem", {
-        actorName: item.actor.name,
-        actorType: item.actor.type,
-        itemName: item.name,
-        itemType: item.type,
-      }),
-    );
-    return false;
-  }
-}

templates/sheets/actor/components/effect-list-entry.hbs

@@ -9,7 +9,7 @@ SPDX-License-Identifier: MIT
 !-- Render an effect list entry row.
 !-- @param effectData: The data of the item.
 --}}
-<li class="ds4-embedded-document-list__row effect" data-effect-uuid="{{effectData.uuid}}" data-effect-id="{{effectData.id}}">
+<li class="ds4-embedded-document-list__row effect" data-effect-uuid="{{effectData.uuid}}">
     {{!-- enabled --}}
     <input class="ds4-embedded-document-list__editable ds4-embedded-document-list__editable--checkbox change-effect"
         type="checkbox" {{checked (ne effectData.disabled true)}} data-dtype="Boolean" data-property="disabled"

templates/sheets/actor/components/item-list-entry.hbs

@@ -15,7 +15,7 @@ SPDX-License-Identifier: MIT
 !-- @param hideDescription: A flag to disable the description column.
 !-- @param @partial-block: Custom column headers can be passed using the partial block.
 --}}
-<li class="ds4-embedded-document-list__row item" data-item-uuid="{{item.uuid}}" data-item-id="{{item.id}}">
+<li class="ds4-embedded-document-list__row item" data-item-uuid="{{item.uuid}}">
     {{!-- equipped --}}
     {{#if isEquipable}}
     <input class="ds4-embedded-document-list__editable ds4-embedded-document-list__editable--checkbox change-item"