Correctly model the different armor types of the SRD #32

New issue

Closed

opened 2023-06-20 18:18:25 +02:00 by migration-script · 0 comments

migration-script commented

2023-06-20 18:18:25 +02:00

Story

As a ds4 user, I want the different armor types to correctly model what is described by the SRD so that I can follow the games rules properly.

Description

Currently, we have 2 types of items which provide armor:

armor
shields

For armor has a couple of different armorTypes (body, helmet, vambrace, greaves, vambraceGreaves) and materialTypes (cloth, leather, chain, plate). This does not properly reflect what is defined by the SRD. In particular, the SRD doesn't define any material types for helmets and greaves / vambrace. We should adjust our model to correctly fit the SRD. In order to do this, helmets and greaves / vambrace should be modeled as separate item types, similar to how this is already done with shields.

Acceptance criteria

There are 4 different item types which provide armor:
- chestArmor
- helmet
- greavesVambraces
- shield
chestArmor armor has a property materialType, which can be one of cloth, leather, chain, and plate.
chestArmor does not have a property armorType any more as armor only represents chest armor now.
helmet does not have any special properties (similar to how shield is currently implemented).
greavesVambraces hav a property type, which can be one of greaves, vambraces, and greavesAndVambraces.
shields don't have any special properties, i.e. there are no changes to them.
All of these are still shown in the "Armor" section of the actor sheets.

# Story As a ds4 user, I want the different armor types to correctly model what is described by the SRD so that I can follow the games rules properly. # Description Currently, we have 2 types of items which provide armor: * `armor` * `shield`s For armor has a couple of different `armorType`s (`body`, `helmet`, `vambrace`, `greaves`, `vambraceGreaves`) and `materialTypes` (`cloth`, `leather`, `chain`, `plate`). This does not properly reflect what is defined by the SRD. In particular, the SRD doesn't define any material types for helmets and greaves / vambrace. We should adjust our model to correctly fit the SRD. In order to do this, helmets and greaves / vambrace should be modeled as separate item types, similar to how this is already done with shields. # Acceptance criteria 1. There are 4 different item types which provide armor: - `chestArmor` - `helmet` - `greavesVambraces` - `shield` 2. `chestArmor` armor has a property `materialType`, which can be one of `cloth`, `leather`, `chain`, and `plate`. 3. `chestArmor` does not have a property `armorType` any more as armor only represents chest armor now. 4. `helmet` does not have any special properties (similar to how shield is currently implemented). 5. `greavesVambraces` hav a property `type`, which can be one of `greaves`, `vambraces`, and `greavesAndVambraces`. 6. `shield`s don't have any special properties, i.e. there are no changes to them. 7. All of these are still shown in the "Armor" section of the actor sheets.