Switch to using foundry-vtt-types type definitions #36

New issue

Closed

opened 2023-06-20 18:18:28 +02:00 by migration-script · 0 comments

migration-script commented

2023-06-20 18:18:28 +02:00

Story

As a developer, I want to use properly maintained type definitions for the foundry vtt types so that I can rely more on the types being correct.

Description

foundry-pc-types is not properly maintained anymore. We are already using our own fork of it, which tends to be quite a bit of work. Instead, we should switch to using foundry-vtt-types, which is an attempt to provide properly maintained types and has more community support. If we need any particular changes to those types, instead of creating a fork, we should upstream the changes.

Acceptance criteria

foundry-pc-types is removed
foundry-vtt-types is used for foundry type definitions instead (0.7.9 branch).
npm run update updates the foundry-vtt-types to the latest version (of the 0.7.9 branch).

# Story As a developer, I want to use properly maintained type definitions for the foundry vtt types so that I can rely more on the types being correct. # Description foundry-pc-types is not properly maintained anymore. We are already using our own fork of it, which tends to be quite a bit of work. Instead, we should switch to using [foundry-vtt-types](https://github.com/kmoschcau/foundry-vtt-types), which is an attempt to provide properly maintained types and has more community support. If we need any particular changes to those types, instead of creating a fork, we should upstream the changes. # Acceptance criteria 1. foundry-pc-types is removed 2. [foundry-vtt-types](https://github.com/kmoschcau/foundry-vtt-types) is used for foundry type definitions instead (0.7.9 branch). 3. npm run update updates the foundry-vtt-types to the latest version (of the 0.7.9 branch).