Roll Library Refinements #84

New issue

Closed

opened 2023-06-20 18:18:56 +02:00 by migration-script · 0 comments

migration-script commented

2023-06-20 18:18:56 +02:00

The Roll lib is lacking the following cases:

Test case: need to swap third and second dice to maximize result. (eg. testValue: 36, dice 15,4,12)
Test case: First dice a 1 with a regular roll is not considered a crit success
Add handling for weird "swap first and last dice"-edgecase.
Add a config flag for slaying dice roll. A 1 on first dice is considered a crit success.
Add a config flag for slaying dice followup roll. A 20 on first dice is not considered a crit fail then.

The Roll lib is lacking the following cases: - [x] Test case: need to swap third and second dice to maximize result. (eg. testValue: 36, dice 15,4,12) - [x] Test case: First dice a `1` with a regular roll is not considered a crit success - [x] Add handling for weird "swap first and last dice"-edgecase. - [x] Add a config flag for slaying dice roll. A `1` on first dice is considered a crit success. - [x] Add a config flag for slaying dice followup roll. A `20` on first dice is not considered a crit fail then.