address code review comments

This commit is contained in:
Johannes Loher 2021-01-18 19:11:13 +01:00
parent fc144aa3f6
commit 7e4c5059ca
5 changed files with 8 additions and 9 deletions

View file

@ -57,8 +57,8 @@
"DS4.ItemTypeLanguagePlural": "Sprachen", "DS4.ItemTypeLanguagePlural": "Sprachen",
"DS4.ItemTypeAlphabet": "Schriftzeichen", "DS4.ItemTypeAlphabet": "Schriftzeichen",
"DS4.ItemTypeAlphabetPlural": "Schriftzeichen", "DS4.ItemTypeAlphabetPlural": "Schriftzeichen",
"DS4.ItemTypeSpecialCreatureAbility": "Besondere Kreaturefähigkeit", "DS4.ItemTypeSpecialCreatureAbility": "Besondere Kreaturenfähigkeit",
"DS4.ItemTypeSpecialCreatureAbilityPlural": "Besondere Kreaturefähigkeiten", "DS4.ItemTypeSpecialCreatureAbilityPlural": "Besondere Kreaturenfähigkeiten",
"DS4.ArmorType": "Panzerungstyp", "DS4.ArmorType": "Panzerungstyp",
"DS4.ArmorTypeAbbr": "PAT", "DS4.ArmorTypeAbbr": "PAT",
"DS4.ArmorMaterialType": "Material Typ", "DS4.ArmorMaterialType": "Material Typ",
@ -145,7 +145,7 @@
"DS4.CharacterProfileBirthplace": "Geburtsort", "DS4.CharacterProfileBirthplace": "Geburtsort",
"DS4.CharacterProfileAge": "Alter", "DS4.CharacterProfileAge": "Alter",
"DS4.CharacterProfileHeight": "Größe", "DS4.CharacterProfileHeight": "Größe",
"DS4.ProfilHairColor": "Haarfarbe", "DS4.ProfilEHairColor": "Haarfarbe",
"DS4.CharacterProfileWeight": "Gewicht", "DS4.CharacterProfileWeight": "Gewicht",
"DS4.CharacterProfileEyeColor": "Augenfarbe", "DS4.CharacterProfileEyeColor": "Augenfarbe",
"DS4.CharacterProfileSpecialCharacteristics": "Besondere Eigenschaften", "DS4.CharacterProfileSpecialCharacteristics": "Besondere Eigenschaften",

View file

@ -145,7 +145,7 @@
"DS4.CharacterProfileBirthplace": "Birthplace", "DS4.CharacterProfileBirthplace": "Birthplace",
"DS4.CharacterProfileAge": "Age", "DS4.CharacterProfileAge": "Age",
"DS4.CharacterProfileHeight": "Height", "DS4.CharacterProfileHeight": "Height",
"DS4.ProfilHairColor": "Hair Color", "DS4.ProfilEHairColor": "Hair Color",
"DS4.CharacterProfileWeight": "Weight", "DS4.CharacterProfileWeight": "Weight",
"DS4.CharacterProfileEyeColor": "Eye Color", "DS4.CharacterProfileEyeColor": "Eye Color",
"DS4.CharacterProfileSpecialCharacteristics": "Special Characteristics", "DS4.CharacterProfileSpecialCharacteristics": "Special Characteristics",

View file

@ -204,7 +204,7 @@ export const DS4 = {
birthplace: "DS4.CharacterProfileBirthplace", birthplace: "DS4.CharacterProfileBirthplace",
age: "DS4.CharacterProfileAge", age: "DS4.CharacterProfileAge",
height: "DS4.CharacterProfileHeight", height: "DS4.CharacterProfileHeight",
hairColor: "DS4.ProfilHairColor", hairColor: "DS4.ProfilEHairColor",
weight: "DS4.CharacterProfileWeight", weight: "DS4.CharacterProfileWeight",
eyeColor: "DS4.CharacterProfileEyeColor", eyeColor: "DS4.CharacterProfileEyeColor",
specialCharacteristics: "DS4.CharacterProfileSpecialCharacteristics", specialCharacteristics: "DS4.CharacterProfileSpecialCharacteristics",
@ -239,7 +239,7 @@ export const DS4 = {
}, },
/** /**
* Define the different size categories a creatures fall into * Define the different size categories creatures fall into
*/ */
creatureSizeCategories: { creatureSizeCategories: {
tiny: "DS4.CreatureSizeCategoryTiny", tiny: "DS4.CreatureSizeCategoryTiny",

View file

@ -1,4 +1,3 @@
{{!-- TODO: For items list: only show header, if list is not empty --}}
{{!-- TODO: Refactor to avoid code duplication with special-creature-abilites-overview and talents-overview --}} {{!-- TODO: Refactor to avoid code duplication with special-creature-abilites-overview and talents-overview --}}
{{!-- ======================================================================== --}} {{!-- ======================================================================== --}}

View file

@ -3,8 +3,8 @@
<div class="grid grid-3col basic-properties"> <div class="grid grid-3col basic-properties">
<div class="basic-property"> <div class="basic-property">
<label>{{localize "DS4.SpecialCreatureAbilityExperiencePoints"}}</label> <label>{{localize "DS4.SpecialCreatureAbilityExperiencePoints"}}</label>
<input type="number" name="data.experiencePoints" value="{{data.experiencePoints}}" placeholder="0" <input type="number" min="0" step="1" name="data.experiencePoints" value="{{data.experiencePoints}}"
data-dtype="Number" /> placeholder="0" data-dtype="Number" />
</div> </div>
</div> </div>
{{/systems/ds4/templates/item/partials/sheet-header.hbs}} {{/systems/ds4/templates/item/partials/sheet-header.hbs}}