dungeonslayers/ds4
dungeonslayers/ds4
3
0
Fork 0
Code Issues 9 Pull requests 7 Projects Releases 10 Packages 1 Activity

small adjustments to TODO comments

Browse source
This commit is contained in:
Johannes Loher 2021-01-26 03:58:03 +01:00
parent 62cc5a0e7c
commit a0c4d1c4d9
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/module/actor/sheets/actor-sheet.ts
View file

@ -117,7 +117,7 @@ export class DS4ActorSheet extends ActorSheet<unknown, DS4Actor> {
}; };
// Finally, create the item! // Finally, create the item!
return this.actor.createOwnedItem(itemData as DS4ItemData); // TODO(types) Improve upstream typing of createOwnedItem. It is possible to leave parts out here. return this.actor.createOwnedItem(itemData as DS4ItemData); // TODO(types): Improve upstream typing of createOwnedItem. It is possible to leave parts out here.
} }
/** /**

4
src/module/item/item-sheet.ts
View file

@ -63,7 +63,7 @@ export class DS4ItemSheet extends ItemSheet<unknown, DS4Item> {
const position = super.setPosition(options); const position = super.setPosition(options);
if ("find" in this.element) { if ("find" in this.element) {
const sheetBody = this.element.find(".sheet-body"); const sheetBody = this.element.find(".sheet-body");
const bodyHeight = (position.height as number) - 192; // TODO: remove type cast once https://github.com/kmoschcau/foundry-vtt-types/pull/214 is merged const bodyHeight = (position.height as number) - 192; // TODO(types): remove type cast once https://github.com/kmoschcau/foundry-vtt-types/pull/214 is merged
sheetBody.css("height", bodyHeight); sheetBody.css("height", bodyHeight);
} else { } else {
console.log("Failure setting position."); console.log("Failure setting position.");
@ -99,7 +99,7 @@ export class DS4ItemSheet extends ItemSheet<unknown, DS4Item> {
case "create": case "create":
return this._createActiveEffect(); return this._createActiveEffect();
case "edit": case "edit":
const effect = this.item["effects"].get(li.data("effectId")); // TODO replace with item.effect once https://github.com/kmoschcau/foundry-vtt-types/pull/216 is merged const effect = this.item["effects"].get(li.data("effectId")); // TODO(types): replace with item.effect once https://github.com/kmoschcau/foundry-vtt-types/pull/216 is merged
return effect.sheet.render(true); return effect.sheet.render(true);
case "delete": { case "delete": {
return this.item.deleteEmbeddedEntity("ActiveEffect", li.data("effectId")); return this.item.deleteEmbeddedEntity("ActiveEffect", li.data("effectId"));